Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a GitHub release for each action release #2517

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Create a GitHub release for each action release #2517

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b4db1e
Create a GitHub release for each action release
aeisenberg Oct 2, 2024
d545e9b
Add a partial changelog when releasing
aeisenberg Oct 10, 2024
2b89f7b
Create the changelog before creating the mergeback branch
aeisenberg Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/post-release-mergeback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,14 @@ jobs:
--body "${pr_body}" \
--assignee "${GITHUB_ACTOR}" \
--draft

- name: Create the GitHub release
env:
VERSION: "${{ steps.getVersion.outputs.version }}"
run: |
# Do not mark this release as latest. The most recent CLI release must be marked as latest.
gh release create \
"${VERSION}" \
--latest=false \
-t "${VERSION}" \
-F CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this include just the release notes for the latest release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates release notes for all releases. Looks like this: https://github.com/aeisenberg/codeql-action/releases/tag/v1.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we could pull out just the relevant section. We already have some code to do that in the .github/update-release-branch.py script which we could reuse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll what I can do. There should also be an easy link to the full changelog.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aeisenberg, is this something you still plan to address, or shall we review this PR as is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...this slipped through. Let me take a look at this before you review.

Loading