Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Go workaround warning if autobuilder ran #1926

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Suppress Go workaround warning if autobuilder ran #1926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eccc6d
Suppress Go workaround warning if autobuilder ran
mbg Oct 6, 2023
ffaea6c
Merge branch 'main' into mbg/suppress-go-workaround-warning
mbg Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Suppress Go workaround warning if autobuilder ran
  • Loading branch information
@mbg
mbg committed Oct 6, 2023
commit 4eccc6dac4b5a7edb9bbde25bd50ec75876d62d4
3 changes: 2 additions & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/analyze-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ async function run() {
// precedence in the PATH, thus potentially circumventing our workaround that allows tracing to work.
const goWrapperPath = process.env[EnvVar.GO_BINARY_LOCATION];

if (goWrapperPath !== undefined) {
if (
process.env[EnvVar.DID_AUTOBUILD_GOLANG] !== "true" &&
goWrapperPath !== undefined
) {
const goBinaryPath = await safeWhich("go");

if (goWrapperPath !== goBinaryPath) {
Expand Down
Loading