Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading cgroup limits on ubuntu-20.04 #1891

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Sep 18, 2023

Fix an issue resolving RAM on the ubuntu-20.04 Actions runner image. When running on Ubuntu 20.04, /sys/fs/cgroup/memory/memory.limit_in_bytes sometimes returns MAX_INT to indicate a lack of constraints, which we weren't handling properly.

This PR starts running CodeQL against all supported Actions runner images to ensure that we will catch issues like this in CI in the future.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@henrymercer henrymercer changed the title Fix cgroup limits Fix reading cgroup limits on ubuntu-20.04 Sep 18, 2023
@henrymercer henrymercer marked this pull request as ready for review September 18, 2023 13:05
@henrymercer henrymercer requested a review from a team as a code owner September 18, 2023 13:05
cklin
cklin previously approved these changes Sep 18, 2023
src/util.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cklin cklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henrymercer henrymercer merged commit f3a128e into main Sep 18, 2023
353 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-cgroup-limits branch September 18, 2023 16:25
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants