Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to changenote for custom config #1666

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

aeisenberg
Copy link
Contributor

Also, use a better link in the readme.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner May 1, 2023 18:01
CHANGELOG.md Outdated
@@ -2,7 +2,7 @@

## [UNRELEASED]

- You can now configure CodeQL within your code scanning workflow by passing a `config` input to the `init` Action. [#1590](https://github.com/github/codeql-action/pull/1590)
- You can now configure CodeQL within your code scanning workflow by passing a `config` input to the `init` Action. See [Using a custom configuration file](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning#using-a-custom-configuration-file) for more information about configuring code scanning. [#1590](https://github.com/github/codeql-action/pull/1590)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using https://aka.ms/code-scanning-docs/config-file in both places -- it redirects to the link you have here. Then we can modify the link in future without having to update the text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah...yes. Thanks.

Also, use a better link in the readme.
@aeisenberg aeisenberg enabled auto-merge May 1, 2023 18:35
@aeisenberg aeisenberg merged commit 8ca5570 into main May 1, 2023
@aeisenberg aeisenberg deleted the aeisenberg/readme-update branch May 1, 2023 22:07
@github-actions github-actions bot mentioned this pull request May 4, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants