Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload input values and logic #1598

Merged
merged 20 commits into from
Mar 23, 2023
Merged

Update upload input values and logic #1598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9894ad1
Update upload input description in `analyze`
angelapwen Mar 21, 2023
4052ce5
Update failed runs' upload SARIF logic
angelapwen Mar 21, 2023
a99d06f
Update green runs' upload SARIF logic
angelapwen Mar 21, 2023
452dc6e
Add test cases for `failure-only`, `never`, and unrecognized input
angelapwen Mar 21, 2023
cb6d164
Minor refactoring
angelapwen Mar 21, 2023
8075d10
Replace `false` with `never` in existing checks
angelapwen Mar 21, 2023
7676afe
Fall back to `always` for unrecognized input
angelapwen Mar 22, 2023
fb18766
Add CHANGELOG entry
angelapwen Mar 22, 2023
04e3995
Add unit tests for always, true, false cases
angelapwen Mar 22, 2023
3270250
Clarify CHANGELOG and Action input description
angelapwen Mar 22, 2023
7e7bc84
Specify upload skips rather than fails in test
angelapwen Mar 22, 2023
cde6edb
Refactor relevant into helper method
angelapwen Mar 22, 2023
2a441e3
Further documentation improvements
angelapwen Mar 22, 2023
690a1ab
Update input description to match existing ones
angelapwen Mar 22, 2023
13a94c3
Refactor utility function per PR review
angelapwen Mar 22, 2023
4469ee6
Refactor test cases into loop
angelapwen Mar 22, 2023
707a6bb
Make `getUploadValue` synchronous
angelapwen Mar 23, 2023
7929472
Update comment
angelapwen Mar 23, 2023
54e08db
Use switch statement
angelapwen Mar 23, 2023
532e9ec
Stop `await`ing non async function
angelapwen Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace false with never in existing checks
  • Loading branch information
@angelapwen
angelapwen committed Mar 23, 2023
commit 8075d10d0348964a08717d6f627ea65b9fd55fbf
2 changes: 1 addition & 1 deletion .github/query-filter-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ runs:
with:
output: ${{ runner.temp }}/results
upload-database: false
upload: false
upload: never
env:
CODEQL_ACTION_TEST_MODE: "true"
- name: Check SARIF
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/__javascript-source-root.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/__upload-ref-sha-input.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/__with-checkout-path.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/expected-queries-runs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
with:
output: ${{ runner.temp }}/results
upload-database: false
upload: false
upload: never

- name: Check Sarif
uses: ./../action/.github/check-sarif
Expand Down
2 changes: 1 addition & 1 deletion pr-checks/checks/javascript-source-root.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ steps:
with:
upload-database: false
skip-queries: true
upload: false
upload: never
- name: Assert database exists
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion pr-checks/checks/upload-ref-sha-input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ steps:
upload-database: false
ref: 'refs/heads/main'
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
upload: false
upload: never
- uses: ./../action/upload-sarif
with:
ref: 'refs/heads/main'
Expand Down
2 changes: 1 addition & 1 deletion pr-checks/checks/with-checkout-path.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ steps:
checkout_path: x/y/z/some-path/tests/multi-language-repo
ref: v1.1.0
sha: 474bbf07f9247ffe1856c6a0f94aeeb10e7afee6
upload: false
upload: never
upload-database: false

- uses: ./../action/upload-sarif
Expand Down