-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new configuration Parameter #1590
Conversation
- Write test to check it is read from configuration - Update documentation
@henrymercer @AlonaHlobina : I have renamed the action parameter to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Some suggestions to docs and code.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
Co-authored-by: Henry Mercer <henry.mercer@me.com>
Co-authored-by: Henry Mercer <henry.mercer@me.com>
Co-authored-by: Henry Mercer <henry.mercer@me.com>
Co-authored-by: Henry Mercer <henry.mercer@me.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — this looks good, just some minor followup comments. Your PR checks failed due to hitting API rate limits. They should hopefully pass on a retry. If not, we can try to find a workaround. I am not sure why your fork cannot get CodeQL CLI 2.12.6. If you're still hitting this error, please provide us an error message and repro steps so we can investigate.
const inputFileContents = ` | ||
name: my config | ||
queries: | ||
- uses: ./foo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: It'd be clearer to extract foo
into a variable so we can see more easily why we're creating the foo
directory and referencing foo
later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. Could you merge in main
and rebuild so we can run the PR checks?
I assume this will also support the Over in we'd like to configure CodeQL to ignore two files, and seemed like overkill to have to create the indirection of a separate config file just to specify those two files... |
@jeffwidman 👋 Yes, all keys supported by the config file, including |
What's the status of this PR? Are we just waiting for a merge with main? I don't have push access to this fork, or else I would do it. |
If the PR checks pass, I'm happy with the PR. @tgrall Would you mind merging in main and rebuilding the Action so we can run the checks and merge? |
I'll take this PR over. Superseded by #1665. |
Merge / deployment checklist
configuration
parameter is not well formatted.close #1589 1589