Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-setup: Don't allow Poetry to make venv in project #1419

Merged
merged 4 commits into from
Dec 6, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
python-setup: Apply suggestions from code review
  • Loading branch information
RasmusWL authored Dec 6, 2022
commit 27c143845593aafc0350ab04402e827bb5378ccd
1 change: 1 addition & 0 deletions python-setup/auto_install_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def install_packages_with_poetry():
# Projects that specify `in-project = true` in their poetry.toml would get the
# venv created inside the repo directory, which would cause CodeQL to consider
# it as user-written code. We don't want this to happen.
# see https://python-poetry.org/docs/configuration/#virtualenvsin-project
"POETRY_VIRTUALENVS_IN_PROJECT": "False",
RasmusWL marked this conversation as resolved.
Show resolved Hide resolved
}

Expand Down