Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More readable error message for invalid queries block and invalid query-filters block #1208

Merged
merged 5 commits into from
Aug 23, 2022
Merged

More readable error message for invalid queries block and invalid query-filters block #1208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fba13b0
More readable error message for invalid `queries` block
aeisenberg Aug 15, 2022
5861352
Better error messages for invalid queries and query filters blocks
aeisenberg Aug 23, 2022
ac92a02
Merge remote-tracking branch 'upstream/main' into aeisenberg/better-e…
aeisenberg Aug 23, 2022
9af066e
Update changelog
aeisenberg Aug 23, 2022
e379edd
Update CHANGELOG.md
aeisenberg Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
More readable error message for invalid queries block 
When someone creates an invalid `queries` entry in the codeql config
file, like this:

```
queries:
  - foo.ql
```

THe error message is confusing, looking like this:

```
  Error: Cannot use 'in' operator to search for 'uses' in ql/ql/src
  TypeError: Cannot use 'in' operator to search for 'uses' in ql/ql/src
      at loadConfig (/home/runner/work/_actions/github/codeql-action/71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca/lib/config-utils.js:577:41)
```

With this change, the error message is more comprehensible:

`queries must be an array, with each entry having a 'uses' property`
  • Loading branch information
@aeisenberg
aeisenberg committed Aug 15, 2022
commit fba13b00924344f67d823d5125d86e4117b0a7f0
11 changes: 7 additions & 4 deletions lib/config-utils.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading