-
Couldn't load subscription status.
- Fork 16
feat: allow github app authentication #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a7acc9 to
843507b
Compare
|
Unable to test superlinter locally due to super-linter/super-linter#5320. I'm watching that PR. So I will push fixes if any issues superlinter GitHub Action finds 😄 |
- [x] add github app env variables to env.py and test - [x] setup requirements-test.txt for local testing - [x] change python-ci workflows to use new requirements-test.txt file - [x] add all possible env vars to .env-example, group and alphabetize - [x] purposefully clear out env vars before each env var test, just in case developer loaded .env into local shell manually (like I did) - [x] add flag to get_env_vars method to determine when to load .env file - [x] Update README with example and variable information Signed-off-by: jmeridth <jmeridth@gmail.com>
843507b to
014b544
Compare
|
|
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
when using os.getenv it can return string or None. Changed token variable to be same type (str | None) Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
|
Going to run |
|
Taking a deeper look at this today! |
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
|
Clearer documentation ftw. Thank you @zkoppert |
Signed-off-by: Zack Koppert <zkoppert@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingLocal Testing and Linting
Testing
Linting
Reviewer
bug,documentation,enhancement,infrastructure, orbreaking