Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Free Art License 1.3 #677

Open
wants to merge 7 commits into
base: gh-pages
Choose a base branch
from
Open

Add Free Art License 1.3 #677

wants to merge 7 commits into from

Conversation

lkeane
Copy link

@lkeane lkeane commented Aug 17, 2019

Add Free Art License 1.3

Related Issue: #314

Search for possible example uses

Add Free Art License 1.3

Related Issue: github#314
_licenses/lal-1.3.txt Outdated Show resolved Hide resolved
dans le respect des conditions suivantes :

1. celles prévues à l'article 2.2 en cas de diffusion de la copie modifiée
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine the license text must be copied from https://github.com/spdx/license-list-data/blob/7364995d38090ad40b8aa54d99b322ac8730d2e1/text/LAL-1.3.txt ... that's definitely the right place to start, but it looks like it has some quirks (ie bugs in the SPDX XML markup and/or XML-to-text rendering); this line stands out, as do the doublespaced list items.

Do you know of a plain text version (French) that has been published by artlibre.org and/or is in wide use to compare against? I guess the examples requested above will be good indicators.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strange spacing is in the original text, which is http://artlibre.org/
It's remains at https://spdx.org/licenses/LAL-1.3.html and in their repositories
There is also https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Licence_Art_Libre

Wikipedia says that ": ; ? and ! are always preceded by a thin unbreakable space". I'm assuming full width spaces were used, and it's breaking that line. Elsewhere it mentions nonbreaking spaces for before and after those characters: https://en.wikipedia.org/wiki/French_orthography#Punctuation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I saw that the spacing around punctuation is in the original. I meant the spacing between lines, and in the one line I'm highlighting here, oddly aggressive line wrapping just before punctuation. In any case, let's see what the full French text examples you find look like, and we'll see if any issues or PRs should be filed with SPDX about their text rendered version (which I very much want to be aligned with).

Copy link
Author

@lkeane lkeane Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the punctuation spacing, I think either U+00A0 or U+202F might look better. Apparently the thin non-breaking space only goes before the punctuation.

For the bigger problem of spacing between lines, it definitely seems like LAL-1.3.xml got thrown off somewhere, it looks like starting at line 47. There is also an (I think) unnecessary/redundant <p> element at line 122 and a missing <br> element at 165. For these reasons I went ahead and made a version, working from GPL-3.0.xml as a pattern. It's at spdx/license-list-XML#915

_licenses/lal-1.3.txt Outdated Show resolved Hide resolved
using:
- Open Source Publishing: https://github.com/osp/osp.workshop.flatland/blob/master/licences/lal.txt
- linuxfr.org: https://github.com/mjourdan/linuxfr-design/blob/master/LICENCE.md
- Oak: https://github.com/Debetux/Oak/blob/master/template/default/LICENCE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, these are French now, but they need to be examples with the full text of the license rather than just statements that a project is under this license.

This comment was marked as off-topic.

_licenses/lal-1.3.txt Outdated Show resolved Hide resolved
Copy link

@HoneyCivik HoneyCivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #0x5296FE5e8467fbE27Fb048dbE19F3447b3A0e708

m14253647g

This comment was marked as off-topic.

Djamma1986

This comment was marked as off-topic.

@S1983tt

This comment was marked as off-topic.

1 similar comment
@S1983tt

This comment was marked as off-topic.

@S1983tt

This comment was marked as off-topic.

@S1983tt

This comment was marked as off-topic.

1 similar comment
@S1983tt

This comment was marked as off-topic.

@S1983tt

This comment was marked as off-topic.

Copy link

@Dioliode Dioliode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DioX

Copy link

@Dioliode Dioliode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DioX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.