Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check .travis.yml ruby verison matches pages #473

Merged
merged 3 commits into from
Jan 4, 2017

Conversation

mlinksva
Copy link
Contributor

@mlinksva mlinksva commented Jan 3, 2017

#472 (comment)

very rough, naive, probably bad implementation

#472 (comment)

very rough, naive, probably bad implementation
Copy link

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrific! ✨ I would recommend also noting the process for bumping the CI Ruby version—should it be in a separate PR or in the same PR but separate commit?

ci_ruby_version = ci_config['rvm'][0]

context "#{ci_config_file} and pages ruby versions" do
it 'do not match' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use the affirmative here, e.g. "Matches" rather than "doesn't match." I'm curious if you prefer the negative!

@mlinksva
Copy link
Contributor Author

mlinksva commented Jan 3, 2017

@parkr would you have process documentation be in test output, like (added text bold):

  1. ci ruby version in .travis.yml and pages ruby version match
    Failure/Error: expect(ci_ruby_version).to eql(pages_ruby_version), msg
    (2.0.0) != (2.3.3) please add a commit bumping in .travis.yml

Or elsewhere?

@parkr
Copy link

parkr commented Jan 4, 2017

In the test output is probably the easiest place!

@mlinksva mlinksva merged commit 8dd25de into gh-pages Jan 4, 2017
@mlinksva mlinksva deleted the ci-ruby-version-test branch January 4, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants