Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle messages that are bigger than issue body limit #266

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

nodeselector
Copy link
Contributor

@nodeselector nodeselector commented Jun 10, 2024

Failing to create the issue comment in the post deploy step causes the deployment to fail, which is likely not the desired behavior. This PR proposes truncating the message if it is too long.

CleanShot 2024-06-10 at 16 15 58@2x

@nodeselector nodeselector force-pushed the truncate-post-deploy-messages branch from fd502c9 to 877eb50 Compare June 10, 2024 23:08
@nodeselector nodeselector changed the title handle messages that are bigger that issue body limit handle messages that are bigger than issue body limit Jun 10, 2024
@GrantBirki GrantBirki added bug Something isn't working enhancement New feature or request labels Jun 10, 2024
@GrantBirki GrantBirki merged commit 97e0c4a into main Jun 10, 2024
4 checks passed
@GrantBirki GrantBirki deleted the truncate-post-deploy-messages branch June 10, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants