Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit Retries #181

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Octokit Retries #181

merged 6 commits into from
Aug 1, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Jul 31, 2023

Octokit Retries

This pull request implements retry logic to GitHub API calls via the @octokit/plugin-retry library

All requests through the octokit client will now use default retry logic. The only exception is the createOrUpdateFileContents() method as it will likely return a 404 if the branch is not created yet through eventual consistency. This allows us to wait for up to 10 seconds, which at this point the branch should exist.

resolves: #180

@GrantBirki GrantBirki added bug Something isn't working enhancement New feature or request labels Jul 31, 2023
@GrantBirki
Copy link
Member Author

Simply re-ordering the imports (8356933) led to quite a big PR diff 🙃

@GrantBirki GrantBirki merged commit d92479f into main Aug 1, 2023
4 checks passed
@GrantBirki GrantBirki deleted the octokit-retries branch August 1, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpError: Branch not found
2 participants