Skip to content

feat: Test priority: "important" and priority: "none" notifications using Guidepup#4

Merged
keithamus merged 2 commits intomainfrom
smockle/guidepup
Oct 17, 2024
Merged

feat: Test priority: "important" and priority: "none" notifications using Guidepup#4
keithamus merged 2 commits intomainfrom
smockle/guidepup

Conversation

@smockle
Copy link
Contributor

@smockle smockle commented Oct 9, 2024

Overview

Part of https://github.com/github/core-ux/issues/346 (requires Hubber login).

This PR adds a test for priority: "important" and priority: "none" notifications. The test is written using Guidepup and Playwright. It can be run with npm test.

Below is a screen recording, with audio, of the test running (and passing). The “Suggested Text” example page is opened, and VoiceOver is started. The textarea is focused, and “a” is typed. The word “acceptable” is suggested as a completion, and the explanatory message “Press right arrow to commit suggestion” is conveyed too. The test validates these are conveyed.

Screen.Recording.2024-10-09.at.5.12.13.PM.mov

Next Steps

  • Write a similar test for NVDA.
  • Run tests in CI1.

Footnotes

  1. CI is the reason I opted to test in Edge. Edge is preinstalled on the macos-latest runners, so we’ll avoid downloading a browser in each CI run.

@smockle smockle requested review from a team as code owners October 9, 2024 21:30
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@smockle smockle requested a review from keithamus October 9, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants