Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ariaNotify method on the Document prototype to extend the ARIA Notification API polyfill beyond just Element. The implementation provides a way to send notifications at the document level.
- Added
Document.prototype.ariaNotifymethod that delegates todocumentElement - Updated the polyfill condition to check for both
ElementandDocumentprototype support - Updated README documentation to reflect the new
Document.prototype.ariaNotifyfunctionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| arianotify-polyfill.js | Implements Document.prototype.ariaNotify method and updates polyfill detection |
| README.md | Updates documentation to mention both Element and Document prototype methods |
Comments suppressed due to low confidence (1)
arianotify-polyfill.js:178
- This condition is redundant since it's already checked at the top of the file (line 3). This nested check will always be true when reached, making the code unreachable if Element.prototype already has ariaNotify.
) {
lindseywild
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
From that issue:
This PR implements
ariaNotifyonDocument.