Skip to content

[GHSA-mrr8-v49w-3333] sweetalert2 v11.6.14 and above contains potentially undesirable behavior #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

limonte
Copy link

@limonte limonte commented Aug 14, 2025

Updates

  • Affected products
  • Description
  • References
  • Summary

Comments

@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 07:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a GitHub Security Advisory (GHSA-mrr8-v49w-3333) to reflect that the potentially undesirable behavior in sweetalert2 has been fixed. The advisory originally documented unwanted audio/video messages on specific TLDs, but now indicates the vulnerability was resolved in version 11.22.4.

Key changes:

  • Updated the advisory to indicate the vulnerability has been fixed in version 11.22.4
  • Modified summary and details to reflect the resolved status
  • Removed references that are no longer relevant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"summary": "sweetalert2 v11.6.14 and above contains potentially undesirable behavior",
"details": "`sweetalert2` versions 11.6.14 and above have potentially undesirable behavior. The package outputs audio and/or video messages that do not pertain to the functionality of the package when run on specific tlds. This functionality is documented on the project's readme",
"summary": "potentially undesirable behavior was removed in v11.22.4",
"details": "The vulnerability was removed from the library",
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The details field is too vague and unhelpful. It should provide more specific information about what the vulnerability was and how it was fixed, rather than just stating 'The vulnerability was removed from the library'.

Suggested change
"details": "The vulnerability was removed from the library",
"details": "In sweetalert2 versions 11.6.14 through 11.22.3, a potentially undesirable behavior allowed certain alert dialogs to be triggered or manipulated in ways that could violate expected application behavior, potentially leading to security or usability issues (CWE-440). This issue was addressed in version 11.22.4 by modifying the library's internal logic to prevent such unexpected dialog behavior, ensuring that alerts function as intended and cannot be misused.",

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot changed the base branch from main to limonte/advisory-improvement-6014 August 14, 2025 07:55
@advisory-database advisory-database bot merged commit 9f702b3 into limonte/advisory-improvement-6014 Aug 14, 2025
4 checks passed
@advisory-database
Copy link
Contributor

Hi @limonte! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the limonte-GHSA-mrr8-v49w-3333 branch August 14, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant