Localization #75
Localization #75
Conversation
Conflicts: src/GitHub.VisualStudio/UI/Views/GitHubConnectContent.xaml
For some reason the ContentPresenter throws in the xaml designer if the font family isn't set.
Resources need to be public so that xaml can get to them. Clear duplicate strings and consolidate everything. Remove unused blocks.
There was a problem hiding this comment.
The whitespace and alignment was all screwed up on this file, so I reformatted it, hence all the apparent changes :/
Conflicts: src/GitHub.VisualStudio/UI/Views/Controls/RepositoryPublishControl.xaml
|
Fixed the rest of the view model strings and updated from master. This should be good for now. |
There was a problem hiding this comment.
At this point, could we remove <Rule Id="CA1303" Action="None" /> so that we get build failures if we add literal strings?
There was a problem hiding this comment.
I should have linked that. https://msdn.microsoft.com/en-us/library/ms182187.aspx?f=255&MSPPError=-2147217396
CA1303: Do not pass literals as localized parameters
A method passes a string literal as a parameter to a constructor or method in the .NET Framework class library and that string should be localizable.
This warning is raised when a literal string is passed as a value to a parameter or property and one or more of the following cases is true:
- The LocalizableAttribute attribute of the parameter or property is set to true.
- The parameter or property name contains "Text", "Message", or "Caption".
- The name of the string parameter that is passed to a Console.Write or Console.WriteLine method is either "value" or "format".
There was a problem hiding this comment.
Yeah, this is a good idea, those conditions won't trigger for our other usages of string literals (logging and such), so should be helpful!
|
|
|
We can deal with #75 (comment) in another PR if there's anything to be done. |
Merge #42 with master, clear up string duplication and unused code, and add new strings.