This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Bump octokit to 0.20.0 #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes added PR Review comment count field
Contributor
|
👍 as is, gonna make it even with master and merge ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps octokit to 0.20, updates the API for breaking changes, and also includes a local octokit fix (not yet upstream) that adds the PR Review comment count field to the PullRequest object (comment counts include commit comments and pr comments, which are stored in two different fields)
The comment count is not actually getting populated right now because the json result of listing PRs doesn't return these fields, but they are returned when we get individual PRs, so this bump is not strictly required right now.
This needs local testing before merging!