This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Catch File I/O exception in GitHub.Exports #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you squash this into one commit? It's small enough to be a self-contained commit. We'll need to cherry-pick it to a PR targeting master, too. |
| File.AppendAllText(defaultLogPath, msg, Encoding.UTF8); | ||
| throw; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The try/catch should be inside the lock, and only around the File.AppendAllText. Also don't throw the exception, if we do that it'll crash Visual Studio.
paladique
force-pushed
the
paladique/fix-exports-crash
branch
4 times, most recently
from
ec67f0e to
48dace0
Compare
whitespace fix wrap try around file operation only remove excess bracket whitespace fixes remove space between keywords
paladique
force-pushed
the
paladique/fix-exports-crash
branch
from
48dace0 to
996d86c
Compare
Contributor
|
✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367. Wrapping in a try/catch. Since this is happening in
Logger.cs, we'll add the exception message to the cache if we continue to get reports about problems here.