This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use Merge instead of Amb on login control. #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #309. `Observable.Amb` "emits all of the items from only the first of these Observables to emit an item or notification". This means that if the user tries to login first to .com with an invalid login, then tries to login to enterprise with a valid login the login from enterprise will be ignored because the .com observable fired first. Instead use `Observable.Merge` which will emit authentication results from both in any order.
Contributor
|
Can we put together a test for this somehow? |
Contributor
Author
|
Hmm yeah, we should I guess! Will work on it. |
Confirmed that the unit test fails on master but passes with the fix.
Contributor
Author
|
Added a unit test. |
Contributor
|
😻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309.
Observable.Amb"emits all of the items from only the firstof these Observables to emit an item or notification". This means that if the user tries to login first to .com with an invalid login, thentries to login to enterprise with a valid login the login from enterprise will be ignored because the .com observable fired first.Instead use
Observable.Mergewhich will emit authentication results from both in any order.