Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix keyboard navigation and focus on clone dialog #2332

Merged
jcansdale merged 13 commits into from
Apr 25, 2019
Merged

Fix keyboard navigation and focus on clone dialog #2332

jcansdale merged 13 commits into from
Apr 25, 2019

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Apr 24, 2019 •
edited
Loading

What this PR does

  • Start with focus on search box
  • Set keyboard tab order for controls

image

How to test

  1. Open the open/clone dialig
  2. Check that focus is on the Search or enter a URL text box
  3. Check pressing tab changes focus to repository list
  4. Check pressing enter would Clone or Open (when repository is selected)
  5. Check pressing tab changes to path box
  6. Check pressing tab changes to Browse... button
  7. Check pressing tab changes to Clone or Open button

Fixes #2323

meaghanlewis
meaghanlewis approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@meaghanlewis meaghanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good functionality wise 👍

@jcansdale jcansdale merged commit becede3 into master Apr 25, 2019
@jcansdale jcansdale deleted the fixes/2323-keyboard-navigation branch April 25, 2019 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@meaghanlewis meaghanlewis meaghanlewis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clone and create dialogs need to be validated for keyboard navigation and startup focus

5 participants

@jcansdale @meaghanlewis @Claude @Codex