Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Replace dormant IRC link with follow on Twitter #2200

Merged
meaghanlewis merged 1 commit into from
Jan 25, 2019
Merged

Replace dormant IRC link with follow on Twitter #2200

meaghanlewis merged 1 commit into from
Jan 25, 2019

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jan 25, 2019 •
edited
Loading

Add a link to follow @githubvs on Twitter.

It looks like some cheeky person has taken @githubvs on GitHub.

How to test

  1. Click Files changed then View file
  2. You should see the following in the README.md
    image
  3. Check that Twitter link points to GitHubVS account
  4. Ideally use an account that isn't already following @GitHubVS

Questions

  • Is the link okay here or should we put it somewhere more prominent?
  • AFAIK no one used the Freenode IRC, I'm assuming it's okay to replace?

@meaghanlewis meaghanlewis merged commit bb67781 into master Jan 25, 2019
@meaghanlewis meaghanlewis deleted the docs/twitter branch January 25, 2019 15:40
@jcansdale jcansdale mentioned this pull request Feb 11, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@StanleyGoldman StanleyGoldman Awaiting requested review from StanleyGoldman

@drguthals drguthals Awaiting requested review from drguthals

1 more reviewer

@meaghanlewis meaghanlewis meaghanlewis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcansdale @meaghanlewis @Claude @Codex