Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Sep 6, 2018

  • Using nuget to get opencov and codecov binaries
  • Providing a powershell script to produce code coverage
  • Using said script in AppVeyor
  • Excluding some flaky tests from code coverage

Copy link
Contributor Author

@StanleyGoldman StanleyGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #1902 into master will decrease coverage by 2.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1902      +/-   ##
=========================================
- Coverage   40.94%   38.4%   -2.55%     
=========================================
  Files         487     487              
  Lines       18868   18669     -199     
  Branches        0    2450    +2450     
=========================================
- Hits         7726    7169     -557     
+ Misses      11142   10954     -188     
- Partials        0     546     +546
Impacted Files Coverage Δ
...ViewModels/GitHubPane/PullRequestCheckViewModel.cs 1.09% <0%> (-81.32%) ⬇️
.../GitHub.Exports/Helpers/NotificationAwareObject.cs 0% <0%> (-50%) ⬇️
...ws/ViewModels/PullRequestReviewCommentViewModel.cs 72.41% <0%> (-25.87%) ⬇️
...InlineReviews/Models/PullRequestSessionLiveFile.cs 80% <0%> (-20%) ⬇️
src/GitHub.App/Services/Translation.cs 42.42% <0%> (-19.7%) ⬇️
...Hub.InlineReviews/Models/PullRequestSessionFile.cs 75% <0%> (-18.75%) ⬇️
src/GitHub.App/Services/OAuthCallbackListener.cs 82.35% <0%> (-17.65%) ⬇️
src/GitHub.App/Services/RepositoryCloneService.cs 75.86% <0%> (-13.8%) ⬇️
src/GitHub.Exports/Models/LocalRepositoryModel.cs 51.31% <0%> (-13.62%) ⬇️
src/GitHub.UI/Helpers/LoadingResourceDictionary.cs 54.83% <0%> (-12.91%) ⬇️
... and 133 more

Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@StanleyGoldman StanleyGoldman merged commit 510154b into master Sep 7, 2018
@StanleyGoldman StanleyGoldman deleted the codecov-again branch September 7, 2018 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants