add OnExit back in and place reset method in IViewModel

Author: paladique

src/GitHub.App/Controllers/UIController.cs

@@ -339,7 +339,8 @@ void ConfigureUIHandlingStates()
                 .OnEntry(tr => RunView(UIViewType.PRCreation, CalculateDirection(tr)))
                 .PermitDynamic(Trigger.Next, () => Go(Trigger.Next))
                 .PermitDynamic(Trigger.Cancel, () => Go(Trigger.Cancel))
-                .PermitDynamic(Trigger.Finish, () => Go(Trigger.Finish));
+                .PermitDynamic(Trigger.Finish, () => Go(Trigger.Finish))
+                .OnExit(() => Reset());
 
             uiStateMachine.Configure(UIViewType.Login)
                 .OnEntry(tr => RunView(UIViewType.Login, CalculateDirection(tr)))

src/GitHub.App/SampleData/SampleViewModels.cs

@@ -122,12 +122,6 @@ public ReactivePropertyValidator<string> RepositoryNameValidator
             private set;
         }
 
-        public ICommand Reset
-        {
-            get;
-            private set;
-        }
-
         public string SafeRepositoryName
         {
             get;

src/GitHub.App/ViewModels/BaseViewModel.cs

@@ -29,5 +29,9 @@ public bool IsBusy
         public virtual void Initialize([AllowNull] ViewWithData data)
         {
         }
+
+        public virtual void Reset()
+        {
+        }
     }
 }

src/GitHub.App/ViewModels/PullRequestCreationViewModel.cs

@@ -189,7 +189,7 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        void Reset()
+       public override void Reset()
         {
             this.PRTitle = string.Empty;
             this.Description = string.Empty;

src/GitHub.Exports/ViewModels/IViewModel.cs

@@ -9,5 +9,6 @@ public interface IViewModel
         ICommand Cancel { get; }
         bool IsShowing { get; }
         void Initialize(ViewWithData data);
+        void Reset();
     }
 }

src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs

@@ -397,5 +397,9 @@ protected override void Dispose(bool disposing)
             }
             base.Dispose(disposing);
         }
+
+        public void Reset()
+        {
+        }
     }
 }

src/UnitTests/GitHub.App/ViewModels/PullRequestCreationViewModelTests.cs

@@ -193,29 +193,32 @@ public void TemplateIsUsedIfPresent()
     }
 
     [Fact]
-    public void FormClearsOnCancel()
+    public async Task FormClearsOnCancel()
     {
         var data = PrepareTestData("octokit.net", "shana", "master", "octokit", "notmaster", "origin", true, true);
         var prservice = new PullRequestService(data.GitClient, data.GitService, data.ServiceProvider.GetOperatingSystem(), Substitute.For<IUsageTracker>());
+
         var vm = new PullRequestCreationViewModel(data.RepositoryHost, data.ActiveRepo, prservice, data.NotificationService);
+        vm.Initialize();
         vm.PRTitle = "a title";
         vm.Description = "a description";
-        vm.CancelCommand.ExecuteAsync();
+        vm.TargetBranch = new BranchModel("notmaster", data.TargetRepo);        
+        await vm.CancelCommand.ExecuteAsync();
 
         Assert.Equal("master", vm.TargetBranch.Name);
         Assert.Equal(string.Empty, vm.PRTitle);
         Assert.Equal(string.Empty, vm.Description);
     }
 
     [Fact]
-    public void FormClearsOnCreation()
+    public async Task FormClearsOnCreation()
     {
         var data = PrepareTestData("octokit.net", "shana", "master", "octokit", "notmaster", "origin", true, true);
         var prservice = new PullRequestService(data.GitClient, data.GitService, data.ServiceProvider.GetOperatingSystem(), Substitute.For<IUsageTracker>());
         var vm = new PullRequestCreationViewModel(data.RepositoryHost, data.ActiveRepo, prservice, data.NotificationService);
         vm.PRTitle = "a title";
         vm.Description = "a description";
-        vm.CreatePullRequest.ExecuteAsync();
+        await vm.CreatePullRequest.ExecuteAsync();
 
         Assert.Equal("master", vm.TargetBranch.Name);
         Assert.Equal(string.Empty, vm.PRTitle);