subscribe in the contstructor set up asserts properly

Author: paladique

src/GitHub.App/ViewModels/PullRequestCreationViewModel.cs

@@ -120,6 +120,9 @@ public PullRequestCreationViewModel(IRepositoryHost repositoryHost, ISimpleRepos
             this.WhenAnyValue(x => x.Initialized, x => x.GitHubRepository, x => x.Description, x => x.IsExecuting)
                 .Select(x => !(x.Item1 && x.Item2 != null && x.Item3 != null && !x.Item4))
                 .Subscribe(x => IsBusy = x);
+
+            CancelCommand.Subscribe(_ => Reset());
+            CreatePullRequest.Subscribe(_ => Reset());
         }
 
         public override void Initialize(ViewWithData data = null)
@@ -148,9 +151,6 @@ public override void Initialize(ViewWithData data = null)
                 Branches = x.ToList();
                 Initialized = true;
             });
-
-            CancelCommand.Subscribe(_ => Reset());
-            CreatePullRequest.Subscribe(_ => Reset());
         }
 
         void SetupValidators()

src/UnitTests/GitHub.App/ViewModels/PullRequestCreationViewModelTests.cs

@@ -198,7 +198,27 @@ public void FormClearsOnCancel()
         var data = PrepareTestData("octokit.net", "shana", "master", "octokit", "notmaster", "origin", true, true);
         var prservice = new PullRequestService(data.GitClient, data.GitService, data.ServiceProvider.GetOperatingSystem(), Substitute.For<IUsageTracker>());
         var vm = new PullRequestCreationViewModel(data.RepositoryHost, data.ActiveRepo, prservice, data.NotificationService);
+        vm.PRTitle = "a title";
+        vm.Description = "a description";
         vm.CancelCommand.ExecuteAsync();
-        Assert.Equal(vm.TargetBranch.Name, "master");
+
+        Assert.Equal("master", vm.TargetBranch.Name);
+        Assert.Equal(string.Empty, vm.PRTitle);
+        Assert.Equal(string.Empty, vm.Description);
+    }
+
+    [Fact]
+    public void FormClearsOnCreation()
+    {
+        var data = PrepareTestData("octokit.net", "shana", "master", "octokit", "notmaster", "origin", true, true);
+        var prservice = new PullRequestService(data.GitClient, data.GitService, data.ServiceProvider.GetOperatingSystem(), Substitute.For<IUsageTracker>());
+        var vm = new PullRequestCreationViewModel(data.RepositoryHost, data.ActiveRepo, prservice, data.NotificationService);
+        vm.PRTitle = "a title";
+        vm.Description = "a description";
+        vm.CreatePullRequest.ExecuteAsync();
+
+        Assert.Equal("master", vm.TargetBranch.Name);
+        Assert.Equal(string.Empty, vm.PRTitle);
+        Assert.Equal(string.Empty, vm.Description);
     }
 }