Add events API to issues

[raphink]

No description provided.

[aendra-rininsland]

The first bit is taken care of in #161, so please remove that. Please also add documentation and unit tests, rebasing once done. Thanks!

[raphink]

As far as I can tell, #161 is for contributors (people who have written
code merged in the project), but my commit adds support for collaborators
(people with commit/admin rights on the project), which is different.

On Wed, 29 Apr 2015 17:15 Ændrew Rininsland notifications@github.com
wrote:

The first bit is taken care of in #161
#161, so please remove that.
Please also add documentation and unit tests. Thanks!

—
Reply to this email directly or view it on GitHub
#180 (comment).

[raphink]

As far as testing, there are no tests for issues yet, and listCollaborators requires a user with priviledges on the repository, which is not the case of the test user (thankfully), so it'll always return a 403.

[aendra-rininsland]

Closed in error; reopening.

[AurelioDeRosa]

Hi @raphink. Are you still interested in updating this PR?

[raphink]

@AurelioDeRosa sure. What changes are still required?

[AurelioDeRosa]

This line can be changed in:

_request('GET', repoPath + "/collaborators", null, cb);

[AurelioDeRosa]

This PR needs tests and also to add documentation to the README file. Thank you for the interest.

[raphink]

@AurelioDeRosa Any comment on #180 (comment) ? Has the situation changed regarding testing since?

[AurelioDeRosa]

We have tests for issues now. You can find them in the test folder.

[raphink]

OK I'll have a look.

[raphink]

@AurelioDeRosa I have rebased and added tests

[raphink]

@AurelioDeRosa @clayreimann any news from this?

[clayreimann]

It's not merged yet (obviously) and two of the three APIs you're adding have been added already, but I'll get issue events in today or tomorrow.

[raphink]

Is collaborators added?

[clayreimann]

I believe so. We have both contributors and collaborators

[clayreimann]

@raphink you can see the docs for contributors and collaborators

[raphink]

Thanks. I'll have to rebase my code.

[clayreimann]

@raphink This is released with version 2.2.0

[raphink]

Thank you.