Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.tiltfile extension for Starlark files #7012

Closed
wants to merge 1 commit into from

Conversation

kevinmartin
Copy link

@kevinmartin kevinmartin commented Aug 23, 2024

Description

Adds *.tiltfile extension to Starlark.

Checklist:

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new extension is used in hundreds of repositories on GitHub.com

🤨 There are only 70 indexed files in the search results. This is a very very long way from our requirements.

  • I have included a real-world usage sample for all extensions added in this PR:

You need to add the file to the PR and also state the license.

I'm going to close this PR as this is a very long way from meeting our usage requirements and it's not likely to meet them any time soon. Feel free to open a new PR when usage meets our requirements.

You can use an override in the meantime.

@lildude lildude closed this Aug 24, 2024
@kevinmartin
Copy link
Author

@lildude Thanks for reviewing this so quickly. I really appreciate the quick turnaround.

Although the *.tiltfile extension currently has few search results, the Tiltfile file name has already been added to the same Starlark language and that has 2.5k+ results.

If anything, I would consider the original addition of Tiltfile as incomplete since it did not consider the *.tiltfile extension. This PR completes the original work from that PR: #4831


As far as the sample, the PR template asks to specify a URL to the sample, but I see now other PRs are adding samples to the samples/ folder which I'm happy to do.

image

Please advise if I can reopen the PR given the above note around the current Tiltfile implementation being incomplete.

@lildude
Copy link
Member

lildude commented Aug 24, 2024

Please advise if I can reopen the PR given the above note around the current Tiltfile implementation being incomplete.

It doesn't matter. We evaluate each filename and extension individually so even if that PR attempted to add the .tiltfile extension, it would have have been held up by the lack of usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants