Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Cylc language. #6832

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

oliver-sanders
Copy link
Contributor

@oliver-sanders oliver-sanders commented May 16, 2024

Description

Add the Cylc language.

Checklist:

@oliver-sanders oliver-sanders requested a review from a team as a code owner May 16, 2024 11:57
* These shebang lines are functional part of the Cylc language (they
  tell Cylc to run the Jinja2 preprocessor), however they cause issues
  with the tests as the Jinja2 preprocessor is not an interpreter which
  can be called on the CLI.
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@oliver-sanders
Copy link
Contributor Author

Just checking in to see if there's anything I can do to help move this forward.

Does the "pending popularity" label mean that we are pending a popularity check by reviewers, or does it mean that the project hasn't yet met the popularity requirements?

@lildude
Copy link
Member

lildude commented Aug 8, 2024

Does the "pending popularity" label mean that we are pending a popularity check by reviewers, or does it mean that the project hasn't yet met the popularity requirements?

It means, based on the results from the search query provided in the PR template, at the time the PR was first checked, there were insufficient files for this language detected on GitHub for it to meet our requirements for inclusion.

This is reassessed whenever a new release is being constructed.

Just checking in to see if there's anything I can do to help move this forward.

Only 🤞 that things improve in popularity in time for the new release 😁

@oliver-sanders
Copy link
Contributor Author

oliver-sanders commented Aug 8, 2024

Great, thanks for the clarification.

The extension usually only appears once per repo so I used a search query which looks for files in the project root which has ~800 results (above the 200 threshold). I failed to mention it was a "once per repo" query, apologies.

I've now also included file extension queries (which will also pick up include files) which gives ~2.4k matches.

Advice for identifying Cylc files
Cylc files will generally start with one of the following:
  • [cylc]
  • [scheduling]
  • [meta]
  • [runtime]
  • [task parameters]
  • #!Jinja2
  • #!EmPy
  • %include
  • {% include ...

@lildude lildude added this pull request to the merge queue Aug 29, 2024
Merged via the queue into github-linguist:master with commit aec591d Aug 29, 2024
5 checks passed
@oliver-sanders oliver-sanders deleted the add-cylc-language branch August 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants