-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Cylc language. #6832
Add the Cylc language. #6832
Conversation
892b15c
to
899671d
Compare
* These shebang lines are functional part of the Cylc language (they tell Cylc to run the Jinja2 preprocessor), however they cause issues with the tests as the Jinja2 preprocessor is not an interpreter which can be called on the CLI.
Just checking in to see if there's anything I can do to help move this forward. Does the "pending popularity" label mean that we are pending a popularity check by reviewers, or does it mean that the project hasn't yet met the popularity requirements? |
It means, based on the results from the search query provided in the PR template, at the time the PR was first checked, there were insufficient files for this language detected on GitHub for it to meet our requirements for inclusion. This is reassessed whenever a new release is being constructed.
Only 🤞 that things improve in popularity in time for the new release 😁 |
Great, thanks for the clarification. The extension usually only appears once per repo so I used a search query which looks for files in the project root which has ~800 results (above the 200 threshold). I failed to mention it was a "once per repo" query, apologies. I've now also included file extension queries (which will also pick up include files) which gives ~2.4k matches. Advice for identifying Cylc filesCylc files will generally start with one of the following:
|
Description
Add the Cylc language.
Checklist:
suite.rc
- ~2.2k.cylc
- ~200#00b3fd