-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make max_tree_size
configurable per-repository
#6806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We want to make Linguist better at detecting all possible languages in very large repos. - This makes a repository's `max_tree_size` value configurable, with the default still set at 100,000.
2 tasks
lildude
approved these changes
May 1, 2024
Please leave the merging to me. |
Alhadis
changed the title
Allow configuring a repository's
Make May 1, 2024
max_tree_size
valuemax_tree_size
configurable per-repository
Alhadis
reviewed
May 1, 2024
- So that we only have to update the `100_000` tree size value once if we do need to change it.
Alhadis
approved these changes
May 1, 2024
2 tasks
Pea1594
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥰
Merging so we can start conducting testing in prod. I won't be making a new release for this as we can vendor directly off master. |
2 tasks
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6805 since that was from my personal fork.
Description
MAX_TREE_SIZE
constant was not high enough.max_tree_size
value configurable in bothinitialize
andincremental
methods, with a default value of 100,000.Checklist: