-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cargo.toml.orig
as TOML filename
#6787
Add Cargo.toml.orig
as TOML filename
#6787
Conversation
I've noticed that some tests for generated files go in |
@spenserblack I believe |
@Alhadis is spot on. |
@lildude One straightforward simplification might be to have - extensions: ['.tsp']
+ auto_test: false
rules:
- language: TypeSpec
pattern: '^(import|using|namespace|interface|op|model|scalar|alias|union|enum)\s'
- language: TSPLIB data
pattern: '^(NAME|TYPE|DIMENSION|EDGE_WEIGHT_TYPE|EDGE_WEIGHT_FORMAT)\s*:' I bring this up because I recently fixed a pedantic test failure in #6775 (392acb1), and all I needed to add to In fact, a lot of the pedantic-level tests could be fixed automatically without a contributor's input (possibly via a command-line switch). Specifically, the alphabetisation of arrays in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
This is a file that is generated by commands like
cargo package
.Checklist:
extensionfilename to a language.extensionfilename is used in hundreds of repositories on GitHub.com