-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pnpm lockfiles as generated #6749
Conversation
Let me know if I need to change or add anything, this is my first PR to this repo |
I see it was decided in #4348 not to mark yarn lockfiles as generated. Would pnpm lockfiles fall under the same boat? If not, why are npm lockfiles marked as generated but not these ones? |
Possibly. The decision to not mark yarn lockfiles came from community feedback so we will not be going back on this unless requested by the wider community.
No idea. Maybe because
Yes, remove the yarn lock related change. You'll also need to add tests and a sample. See #6748 as an example where a file has recently been marked as generated. |
Done. I tried to find a small sample of a pnpm lockfile but this 9k line one was the smallest I could find for a relevant enough project. I hope that's not much of a problem |
It is… hooooge. Please find a smaller one. We don't need a real world file for test fixtures so feel free to write a small representative one by hand if you can't find a smaller one. |
Description
Currently, npm lockfiles (
package-lock.json
) are considered generated files. pnpm lockfiles weren't marked as generated, even though they are indeed generated filesChecklist: