Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WGSL support #6442

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Add WGSL support #6442

merged 10 commits into from
Jun 6, 2023

Conversation

joaogabrielzo
Copy link
Contributor

@joaogabrielzo joaogabrielzo commented Jun 5, 2023

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar: wgsl-grammar
    • I have added a color
      • Hex value: #1a5e9a
      • Rationale: Blue is a present color in the WebGPU logo. This shade is used in the official WGSL doc.
    • I have updated the heuristics to distinguish my language from others using the same extension.

@joaogabrielzo joaogabrielzo requested a review from a team as a code owner June 5, 2023 08:58
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script/add-grammar script should have cached a copy of the repo's license to a yaml file. We need this file as part of this PR.

If you can't find it, possibly because of an issue being hit, you can manually get the file by running: bundle exec licensed cache -c vendor/licenses/config.yml.

As an aside, you don't need to maintain a repo just for the grammar. We can use the wgsl-analyzer repo directly.

@joaogabrielzo
Copy link
Contributor Author

I'm running into troubles trying to install the charlock_holmes gem and that seems to be the reason why the script won't fully work. For the same reason I can't run the command you sent.

@lildude
Copy link
Member

lildude commented Jun 5, 2023

charlock_holmes isn't needed for that command so you should find running gem install licensed and then licensed cache -c vendor/licenses/config.yml will do the trick too.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to correct the ordering in the three locations identified in the test failures. For sorting the submodule, you can use script/sort-submodules (it's run as part of the script/add-grammar script).

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lildude lildude added this pull request to the merge queue Jun 6, 2023
Merged via the queue into github-linguist:master with commit 2b40a3a Jun 6, 2023
@lildude lildude mentioned this pull request Jun 6, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants