-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WGSL support #6442
Add WGSL support #6442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script/add-grammar
script should have cached a copy of the repo's license to a yaml file. We need this file as part of this PR.
If you can't find it, possibly because of an issue being hit, you can manually get the file by running: bundle exec licensed cache -c vendor/licenses/config.yml
.
As an aside, you don't need to maintain a repo just for the grammar. We can use the wgsl-analyzer repo directly.
I'm running into troubles trying to install the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to correct the ordering in the three locations identified in the test failures. For sorting the submodule, you can use script/sort-submodules
(it's run as part of the script/add-grammar
script).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist:
#1a5e9a