Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour to PR Template and tweak CONTRIBUTING and README files #6312

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

lildude
Copy link
Member

@lildude lildude commented Mar 8, 2023

Description

This PR:

  • Adds a colour and explanation to the "I am adding a new language" section of the PR template so we can start documenting why a colour has been chosen. This will help in future when there is a request for a colour change.
  • Updates the contributing guidelines to make it clear we don't wan't "hello world" samples and advises on adding two samples if the new extension matches another.
  • Rewords a few things, removes dead references and updates the list of active maintainers.
  • Adjusts the formatting of the CONTRIBUTING.md and README.md files to make them easier to read in plaintext and to highlight certain callouts.

Checklist:

N/A

@lildude lildude requested a review from a team as a code owner March 8, 2023 11:22
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Alhadis
Copy link
Collaborator

Alhadis commented Mar 11, 2023

Adjusts the formatting of the CONTRIBUTING.md and README.md files to make them easier to read in plaintext

Could we increment the list-items instead of numbering everything 1....? I know this makes diffs a bit noisier when items are added or removed, but such edits don't happen very often, and having properly-numbered items helps establish a sense of location for the reader.

@lildude lildude requested a review from Alhadis March 13, 2023 09:57
@lildude lildude merged commit 9b53b4b into master Mar 15, 2023
@lildude lildude deleted the lildude/add-color-to-pr-template branch March 15, 2023 10:42
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants