Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create independent Snakemake language #6270

Merged
merged 16 commits into from
Mar 8, 2023
Merged

Conversation

SilasK
Copy link
Contributor

@SilasK SilasK commented Feb 1, 2023

Description

Snakemake language was included under python. this PR makes it an independent language under the parent language python.

Colour #419179 taken from the S in the Snakemake logo on https://snakemake.github.io/

Checklist:

@SilasK SilasK requested a review from a team as a code owner February 1, 2023 10:46
@SilasK
Copy link
Contributor Author

SilasK commented Feb 1, 2023

This is a folow up from #3953 and should interest @johanneskoester and maybe @nh13

@SilasK
Copy link
Contributor Author

SilasK commented Feb 1, 2023

I removed the .smk extension from python. In this case there is no other language using this extension. isn't it?

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a .snakefile sample too.

lib/linguist/languages.yml Show resolved Hide resolved
@SilasK
Copy link
Contributor Author

SilasK commented Feb 17, 2023

@johanneskoester is it ok to set https://g.co/kgs/r8SHNw as the snakemake color?

@SilasK SilasK requested a review from lildude February 17, 2023 12:30
@lildude
Copy link
Member

lildude commented Feb 27, 2023

@johanneskoester is it ok to set https://g.co/kgs/r8SHNw as the snakemake color?

Maybe go for #419179 (vs your proposal of #33c68a) as it is the colour of the S in the logo on https://snakemake.github.io/ so it's a colour that can be traced to some sort of "branding"?

@SilasK
Copy link
Contributor Author

SilasK commented Feb 27, 2023

@lildude I changed the color.

@SilasK
Copy link
Contributor Author

SilasK commented Feb 28, 2023

@lildude I think I made all requested changes, didn't I ?

Please add a .snakefile sample too.

@SilasK SilasK requested a review from lildude March 8, 2023 08:33
@lildude lildude merged commit 469adc1 into github-linguist:master Mar 8, 2023
@SilasK
Copy link
Contributor Author

SilasK commented Mar 8, 2023

💯 Thank you @lildude

@corneliusroemer
Copy link

corneliusroemer commented Mar 8, 2023

Amazing stuff! I independently had that idea and opened an issue for it snakemake/snakemake#2153 but that was unnecessary :)

Does linguist cover syntax highlighting or is this somewhere else? Would be the next logical step to get it well supported across the internet. Maybe on highlight.js?

@SilasK
Copy link
Contributor Author

SilasK commented Mar 9, 2023

@corneliusroemer Let's continue discussing on snakemake/snakemake#2153

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants