-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Circom language support #6204
Conversation
Update: Thanks to @krlosMata 's super fast response , the syntax repo now has a license. It is GPL3, however. Let me know if this works @linguist and I'll happily add the syntax to my PR |
That's a deal-breaker. We only accept grammars released under permissive licenses, which rules out copyleft licenses like GPL completely. |
Feared this unfortunately - can we still merge this PR without a grammar for now nonetheless? |
Yes. You can even reappropriate another language's grammar if it happens to provide decent-enough highlighting. |
I will check other licenses that fits the requirements |
I have change the license to MIT in https://github.com/iden3/circom-highlighting-vscode, so it fulfills the specification |
Awesome! Currently out, but will add the grammar when I'm back 👍 |
Added the circom grammar, feel free to have a look again @Alhadis |
Co-authored-by: Colin Seymour <colin@github.com>
Thanks for the review, added your changes @lildude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Added the Circom language
Checklist:
The extension of the new language is used in hundreds of repositories on GitHub.com.
I have included a real-world usage sample for all extensions added in this PR:
I have included a syntax highlighting grammar: Only available grammar I could find was this one by the developers of circom, but it is currently unlicensed.
I have updated the heuristics to distinguish my language from others using the same extension.