-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Visual Basic 6.0 as its own language #6124
Conversation
No samples for .vb6 found on GitHub
In response to requested change: github-linguist#6124 (comment)
And regarding the |
Thanks @lildude! |
Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0? |
No. You'll need to use a manual override. I see this has also been asked and answered in #5824 |
Thanks for the replay. In my view it is not ok to use manual override for VB6 projects on GitHub. I'm personally curious how many VB6 projects are on GitHub. This language is among the most important languages produced by our civilization. I mean, there are new languages that no one has ever heard of that are listed by the linguist, while VB6 is not. VB6 was the most popular computer language in the world for a long time and today it is used by a large mass of scientists and engineers for prototyping projects. Recognizing the VB6 language by default is a decent thing to do on GitHub. I am certain in the end this will be resolved. |
Indeed. As I mentioned in the issue, a heuristic would be needed to do this. Please feel free to submit a PR that implements such a heuristic. Locking this as the discussion should be taking in place in issues now this PR has been merged. |
Description
This pull request adds VB6 as its own language and removes the aliases for VBA that were related to VB6.
This PR aims at solving issue #5824 and takes major inspiration from PR #4725.
For the color, I went with a green close to the green from the VB6 logo.
The extensions provided aren't shared with any languages in languages.yml, so no additional grammar or heuristic is necessary. The VB.NET grammar should suffice for now as it was also the grammar used when adding VBA.
Checklist: