Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDDL #6117

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Add PDDL #6117

merged 6 commits into from
Oct 20, 2022

Conversation

celrm
Copy link
Contributor

@celrm celrm commented Oct 14, 2022

Description

Adds support for PDDL.

Checklist:

@celrm celrm requested a review from a team as a code owner October 14, 2022 20:21
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

We also don't need quite so many nearly identical samples, not the large ones. Please remove the samples that are collapsed in the diff (clear indicator they're too big) and pick the most diverse two or three of the remaining samples and remove the others.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
celrm and others added 2 commits October 19, 2022 10:43
Co-authored-by: Colin Seymour <colin@github.com>
@celrm celrm requested a review from lildude October 19, 2022 09:57
@celrm
Copy link
Contributor Author

celrm commented Oct 19, 2022

See inline comment.

We also don't need quite so many nearly identical samples, not the large ones. Please remove the samples that are collapsed in the diff (clear indicator they're too big) and pick the most diverse two or three of the remaining samples and remove the others.

Thank you, I have applied the suggestions now. Please let me know if there is anything else.

@lildude
Copy link
Member

lildude commented Oct 19, 2022

Running script/list-grammars and committing the changes should fix the tests.

@lildude lildude merged commit 90bb4c6 into github-linguist:master Oct 20, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants