-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repoint razor-plus grammar submodule at new repo #6093
Repoint razor-plus grammar submodule at new repo #6093
Conversation
@lildude Always another yak to shave. The build is currently broken as this grammar disappeared. If you're cool repointing it to my account, I'll keep it online there, or I'm open to axing it entirely. |
If you prefer, we can add it to the github-linguist org. We've done this in the past for abandoned grammars whilst we wait for better alternatives. Or, and probably better, we could switch to the actively maintained grammar in https://github.com/dotnet/razor-tooling/ (grammars are here and should be picked up by the compiler though I've not tested this yet).
Yeah, we can't do that until we've got something else catering for the syntax highlighting just as well. Switching might be the best option for the long run. |
That works for me. I'll initiate a repo transfer there if you have the ability to accept it. And update this PR with a commit pointing there when it's landed.
That sounds like the better option in the long run, but perhaps we ship this first with it in the github-linguist org, then follow on with a switch to that repo once we have had a chance to do some testing with it. I'm going to issue the repo transfer now assuming you're able to accept. Thanks! |
Sounds like a plan. Go for it. I'll deal with it tomorrow. |
Immediately stopped in my tracks by my inability to issue a transfer request to an org I'm not a part of. You'd think I'd know that already. If you have the ability to add me as an org admin temporarily, I can knock that out and update the PR. |
New repo location for razor-plus grammar.
Description
It appears that @austincummings has removed his
razor-plus
repo which contained the grammar used for identifying cshtml files as discussed in #3760. This has broken the build for linguist and is currently preventing other PRs from landing.Because that project was MIT licensed I have pushed a copy of it to my GitHub account, indicated in the README it is unmaintained, and repointed the submodule to the new location. I am also open to just removing that grammar entirely, but it seemed like from the earlier issue users found this grammar useful.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language