Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repoint razor-plus grammar submodule at new repo #6093

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

bval
Copy link
Contributor

@bval bval commented Sep 27, 2022

New repo location for razor-plus grammar.

Description

It appears that @austincummings has removed his razor-plus repo which contained the grammar used for identifying cshtml files as discussed in #3760. This has broken the build for linguist and is currently preventing other PRs from landing.

Because that project was MIT licensed I have pushed a copy of it to my GitHub account, indicated in the README it is unmaintained, and repointed the submodule to the new location. I am also open to just removing that grammar entirely, but it seemed like from the earlier issue users found this grammar useful.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a syntax highlighting grammar: [URL to grammar repo]
    • I have updated the heuristics to distinguish my language from others using the same extension.
  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@bval bval requested a review from a team as a code owner September 27, 2022 17:18
@bval
Copy link
Contributor Author

bval commented Sep 27, 2022

image

@lildude Always another yak to shave. The build is currently broken as this grammar disappeared. If you're cool repointing it to my account, I'll keep it online there, or I'm open to axing it entirely.

@bval bval requested a review from lildude September 27, 2022 17:33
@lildude
Copy link
Member

lildude commented Sep 28, 2022

Because that project was MIT licensed I have pushed a copy of it to my GitHub account, indicated in the README it is unmaintained, and repointed the submodule to the new location.

If you prefer, we can add it to the github-linguist org. We've done this in the past for abandoned grammars whilst we wait for better alternatives.

Or, and probably better, we could switch to the actively maintained grammar in https://github.com/dotnet/razor-tooling/ (grammars are here and should be picked up by the compiler though I've not tested this yet).

I am also open to just removing that grammar entirely, but it seemed like from the earlier issue users found this grammar useful.

Yeah, we can't do that until we've got something else catering for the syntax highlighting just as well. Switching might be the best option for the long run.

@lildude lildude mentioned this pull request Sep 28, 2022
4 tasks
@bval
Copy link
Contributor Author

bval commented Sep 28, 2022

Because that project was MIT licensed I have pushed a copy of it to my GitHub account, indicated in the README it is unmaintained, and repointed the submodule to the new location.

If you prefer, we can add it to the github-linguist org. We've done this in the past for abandoned grammars whilst we wait for better alternatives.

That works for me. I'll initiate a repo transfer there if you have the ability to accept it. And update this PR with a commit pointing there when it's landed.

Or, and probably better, we could switch to the actively maintained grammar in https://github.com/dotnet/razor-tooling/ (grammars are here and should be picked up by the compiler though I've not tested this yet).

That sounds like the better option in the long run, but perhaps we ship this first with it in the github-linguist org, then follow on with a switch to that repo once we have had a chance to do some testing with it.

I'm going to issue the repo transfer now assuming you're able to accept. Thanks!

@lildude
Copy link
Member

lildude commented Sep 28, 2022

Sounds like a plan. Go for it. I'll deal with it tomorrow.

@bval
Copy link
Contributor Author

bval commented Sep 28, 2022

Sounds like a plan. Go for it. I'll deal with it tomorrow.

Immediately stopped in my tracks by my inability to issue a transfer request to an org I'm not a part of. You'd think I'd know that already. If you have the ability to add me as an org admin temporarily, I can knock that out and update the PR.

@bval
Copy link
Contributor Author

bval commented Sep 28, 2022

image

@lildude lildude merged commit 4e424ef into github-linguist:master Sep 29, 2022
@bval bval deleted the fix-broken-razor-plus-grammar branch October 3, 2022 18:45
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants