Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kerboscript and Kickstart language #5981

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

Janik-ux
Copy link
Contributor

@Janik-ux Janik-ux commented Jul 18, 2022

Description

I have added the KerboScript language to the repository. It is the programming language of a mod of Kerbal Space Program called Kerbal Operating System. This mod is widely used under Kerbal Space Program players.
Some other files on github use .ks for example "image kickstart files". Linguist classifies them as KerboScript but I do not know how to write heuristics rules to approach this. These "image kickstart files" are not in the database of linguist and the extension is not anywhere else in languages.yml so I ignored this for now.

Checklist:

@Janik-ux Janik-ux requested a review from a team as a code owner July 18, 2022 15:01
@Janik-ux Janik-ux changed the title Kerboscript Add Kerboscript language Jul 28, 2022
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other files on github use .ks for example "image kickstart files". Linguist classifies them as KerboScript but I do not know how to write heuristics rules to approach this. These "image kickstart files" are not in the database of linguist and the extension is not anywhere else in languages.yml so I ignored this for now.

We can't ignore this. There are way too many files that will be misclassified if we do. You're going to need to identify at least one other user of this extension that is popular enough and as it as part of this PR. If the languages are sufficiently different we can rely on samples and the classifier. If not we'll need heuristics which are just regexes.

@lildude
Copy link
Member

lildude commented Jan 1, 2023

There's no need to keep merging in master. It'll get done just before merging, which won't be happening until you've addressed the point I raised before.

@Janik-ux
Copy link
Contributor Author

Janik-ux commented Jan 2, 2023

I've now added the Kickstart language myself. Unfortunately I didn't find an user who wanted to contribute to this PR.
The ks-extension is also used in Keystore Files, but they are binary and I didn't know how or if at all I should add these files. At the moment linguist does not output any language for keystore files. Maybe this is enough.
The other file types are well classified as far is I have tested.

I have classified the type of kickstart as "data" in languages.yml because it is mainly used to "configure". For that reason I have not set the color.

I have included syntax highlighting grammar from @wgwoods https://github.com/wgwoods/language-kickstart

Sorry for the mess with merging and pushing, I'm relatively new to git...

@Janik-ux Janik-ux changed the title Add Kerboscript language Add Kerboscript and Kickstart language Jan 2, 2023
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. This looks good to go now 👍

@lildude lildude merged commit 9ece9b6 into github-linguist:master Feb 17, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants