Protocol Buffer text format#5716
Merged
Merged
Conversation
Collaborator
|
First of all, please don't add
|
70210d7 to
e7bb32b
Compare
Alhadis
requested changes
Jan 2, 2022
Sample copied from https://github.com/google/nvidia_libs_test/blob/master/cudnn_benchmarks.textproto (Apache-2.0 License).
Alhadis
approved these changes
Jan 2, 2022
Collaborator
Alhadis
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 Thanks for the superb contribution!
Alhadis
requested changes
Jan 2, 2022
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Alhadis
approved these changes
Jan 4, 2022
lildude
requested changes
Feb 8, 2022
Member
lildude
left a comment
There was a problem hiding this comment.
Looks good, just one request: can you please add a sample for the .pbtxt extension.
Contributor
Author
|
Good idea, done. |
lildude
approved these changes
Feb 9, 2022
Contributor
|
Could we also get .pbt added? |
Member
|
Sure, though that would now need to be a new PR as I've just merged this one. |
kalkin
added a commit
to kalkin/file-expert
that referenced
this pull request
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol Buffer text format is a data format, typically parsed together with a Protocol Buffers schema. Thus Protocol Buffers text format is to Protocol Buffers as XML is to XSD.
TextMate Grammar by https://github.com/thejustinwalsh/textproto-grammar (MIT licence)
Fixes #5091.
Checklist:
.pbtxt2000k hits https://github.com/search?q=extension%3Apbtxt&type=Code.textproto100k hits https://github.com/search?q=extension%3Atextproto&type=Code