Use atom's language-sass grammar for SASS and SCSS #4535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using https://github.com/atom/language-sass grammars for both SASS and SCSS languages.
Description
SCCS.tmbundle is badly out of date and no longer maintained. #2965 discussed switching to a different grammar, but it was never followed through.
This PR switches to language-sass instead since it's used by both atom and vscode, and should be better maintained in the future.
Errors
There were a couple of errors associated with this change:
source.html
which doesn't exist. Obviously we do have a grammar for HTML, I'm not sure if there's a way to have this use that?source.css.scss
instead ofsource.css
, which is included in slim. I've reversed the alias incompiler/data.go
which I think should address this, but it seems like the test scripts use a docker image locally so I'm not sure how to test it.Checklist: