Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that script files are checked out with LF line endings. #18

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Ensure that script files are checked out with LF line endings. #18

merged 1 commit into from
Jun 28, 2023

Conversation

peterneave
Copy link
Contributor

When a user checks out the repository on a Windows machine and then loads up the dev container then the script will fail due to the CR characters in the file.

When a user checks out the repository on a Windows machine and then loads up the dev container then the script will fail due to the CR characters in the file.
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@alfredodeza alfredodeza merged commit e1a753e into github-education-resources:main Jun 28, 2023
@peterneave peterneave deleted the explicitly_define_sh_line_endings branch June 29, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants