Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename icf to pma in code #204

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: rename icf to pma in code #204

merged 2 commits into from
Jul 9, 2024

Conversation

sutterj
Copy link
Contributor

@sutterj sutterj commented Jul 8, 2024

Pull Request

Proposed Changes

Screenshot 2024-07-08 at 2 15 32 PM Screenshot 2024-07-08 at 2 15 19 PM

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@sutterj sutterj added the enhancement New feature or request label Jul 8, 2024
@sutterj sutterj requested a review from a team as a code owner July 8, 2024 18:17
ahpook
ahpook approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - rg icf and rg contribution on this branch didn't turn up any missed occurrences. Thanks @sutterj !

@ahpook ahpook merged commit 08990e1 into main Jul 9, 2024
12 checks passed
@ahpook ahpook deleted the sutterj/code-rename branch July 9, 2024 05:56
@ahpook
Copy link
Contributor

ahpook commented Jul 9, 2024

Whups got hasty with the merge button, hope that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahpook ahpook ahpook approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename to "Private Mirrors App"
2 participants
@sutterj @ahpook