fix: tests #69
Merged
fix: tests #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Learned we can't get offenses directly off of the cop, it has to be obtained from the commissioner.investigate method. [rubocop sourcecode about not being able to access offenses off the cop base](https://github.com/rubocop/rubocop/blob/9c6e0ef9039f3602cc0b6e267b7be71ed1110d5b/lib/rubocop/cop/base.rb#L314-L318) Learned we have to provide our cop as the forces argument to the commissioner.investigate if we have our own investigate like we do for the overfetch cop. If we don't it never runs. This is not the case with the heredoc cop because it does not have an investigate method. [rubocop commissioner source code where our custom cop invetigate method is actually called](https://github.com/rubocop/rubocop/blob/9c6e0ef9039f3602cc0b6e267b7be71ed1110d5b/lib/rubocop/cop/commissioner.rb#L85) that calls [this function](https://github.com/rubocop/rubocop/blob/9c6e0ef9039f3602cc0b6e267b7be71ed1110d5b/lib/rubocop/cop/commissioner.rb#L163) and you'll notice the second argument is called cops Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Hannah Yiu <hkly@github.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
According to [this stackoverflow post](https://stackoverflow.com/a/79361034) by using the 1.3.4 version of concurrent-ruby gem, this should fix our logging issues. Signed-off-by: jmeridth <jmeridth@gmail.com>
|
Not the biggest fan of having to pin the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learned we can't get offenses directly off of the cop, it has to be obtained from the commissioner.investigate method.
rubocop sourcecode about not being able to access offenses off the cop base
Learned we have to provide our cop as the forces argument to the commissioner.investigate if we have our own investigate like we do for the overfetch cop. If we don't it never runs. This is not the case with the heredoc cop because it does not have an investigate method.
rubocop commissioner source code where our custom cop invetigate method is actually called that calls this function and you'll notice the second argument is called cops