Skip to content

Allow new enum values config #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

Allow new enum values config #12

merged 2 commits into from
Feb 20, 2024

Conversation

ElvinEfendi
Copy link
Contributor

rmosolgo
rmosolgo reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@rmosolgo rmosolgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this improvement! I agree that this would be a good change. I just have a couple questions about the test coverage.

@ElvinEfendi @rmosolgo
do not set default value explicitly
99e2ea3 
Co-authored-by: Robert Mosolgo <rdmosolgo@gmail.com>
@ElvinEfendi
Copy link
Contributor Author

@rmosolgo thank you for the feedback, committed your suggestions.

@ElvinEfendi ElvinEfendi requested a review from rmosolgo February 20, 2024 13:10
@rmosolgo rmosolgo added this to the 0.21.0 milestone Feb 20, 2024
@rmosolgo rmosolgo merged commit bec141a into github-community-projects:master Feb 20, 2024
@rmosolgo
Copy link
Collaborator

Thanks for this improvement!

@ElvinEfendi ElvinEfendi deleted the allow-new-enum-values-config branch February 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmosolgo rmosolgo Awaiting requested review from rmosolgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ElvinEfendi @rmosolgo