Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for EOL Ruby versions #786

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Drop support for EOL Ruby versions #786

merged 1 commit into from
Apr 10, 2020

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Apr 9, 2020 •
edited
Loading

Background:

Ruby 2.3, 2.4 are both EOL'd. That takes JRuby 9.1 with it, too. Read more in Ruby Maintenance Branches.

Example of 2.5 "news":
https://blog.bigbinary.com/2017/10/24/ruby-2.5-allows-rescue-inside-do-end-blocks.html

Solution

  • Raise the required_ruby_version to 2.5 in gemspec
  • Remove CI matrix elements for unuspported Rubies.
  • Remove all "version-specific" gemfiles.

@olleolleolle
Drop support for EOL Ruby versions
c91b9e1 
  - this raises the required_ruby_version to 2.5
@ioquatix
Copy link
Contributor

Yes, great idea.

@ioquatix ioquatix mentioned this pull request Apr 10, 2020
Merged
@olleolleolle
Copy link
Collaborator Author

In order to be able to use async-http-faraday, we need to be on a supported Ruby version.

@ferrarimarco ferrarimarco self-assigned this Apr 10, 2020
@ferrarimarco ferrarimarco merged commit 8ae2163 into master Apr 10, 2020
@ferrarimarco ferrarimarco deleted the stop-support-for-EOL-rubies branch April 10, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

@skywinder skywinder Awaiting requested review from skywinder

Assignees

@ferrarimarco ferrarimarco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olleolleolle @ioquatix @ferrarimarco