fix: start-runner.ps1 set username #4723
Draft
+57
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to facilitate discussion of issue #4712
Usually the username on windows comes from
runner_run_as: Administrator
. Recently that has broken and it's alwaysSystem
.In
start-runner.ps1
move everything back inside a "Register-ScheduledTask" so the username can be set. This fixes the issue.However,
start-runner.ps1
also included a relatively new section:By removing it, instances fail to terminate. How did this work before? ( in 2023) Why is it necessary to terminate instance from
start-runner.ps1
instead of how it used to work before?By removing
terminate-instances
, the instances continue to run, which is obviously not the desired result.Where should
terminate-instances
be placed, or can the earlier solution handle that task.