feat: add spot termination handler #4176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
changed the title
npalm
force-pushed
the
npalm/feature/spot-termination-handler
branch
from
6a0bf37 to
af45ee3
Compare
npalm
requested review from
stuartp44,
ScottGuymer,
koendelaat and
Brend-Smits
mpas
previously approved these changes
Oct 10, 2024
stuartp44
requested changes
Oct 10, 2024
Co-authored-by: Stuart Pearson <1926002+stuartp44@users.noreply.github.com>
stuartp44
approved these changes
Oct 10, 2024
npalm
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- ## [5.17.0](philips-labs/terraform-aws-github-runner@v5.16.4...v5.17.0) (2024-10-10) ### Features * add spot termination handler ([#4176](https://github.com/philips-labs/terraform-aws-github-runner/issues/4176)) ([8ba0a82](philips-labs/terraform-aws-github-runner@8ba0a82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
npalm
added a commit
that referenced
this pull request
Oct 21, 2024
## Problem Output to termination watcher not updated in PR #4176 --------- Co-authored-by: philips-labs-pr|bot <philips-labs-pr[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a lambda to to log and metric spot termination based on the cloudtrail event
BidEvictedEvent. The feature is experimental and disabled by default.Future directions
The current implemenation only helps to make spot termination visible to an admin team. For the future we want to enrich a runner with information via tagging what job is active, This allows to let the termination handler also inform the user by adding a job annotation once a spot termination occurs.
Migration
No migration is required. By default the watcher is disabled.