start-runner.sh Termination logs never get logged

[stuartp44]

When start-runner.sh is run, there is a line ordering issue where the cloud watch logs can never be sent to cloud watch as the agent is actually stopped before the attempt to flush the logs is performed. This was discovered by @npalm during a internal debug session.

[npalm]

This issue is only the case when using ephemeral runners and using the runner start scripts provided by this repo.

• The log line for termination is written after the cloudwatch agent is stopped. https://github.com/philips-labs/terraform-aws-github-runner/blob/808222fddd2ce98f336086751e32dfdf17c0de24/modules/runners/templates/start-runner.sh#L75
• Second issue, the proces is waiting 10 seconds before termination. To allow cloudwatch to flush. This 10 seconds can conflict with the sclae down and mark the instance as orphan.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

[npalm]

@stuartp44 should we keep this issue open?

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.