Skip to content

Augment model with BGP neighbor update source #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

Fredi-raspall
Copy link
Contributor

@Fredi-raspall Fredi-raspall commented May 20, 2025

This change is needed for preview.

The conversion from gRPC in dataplane is not correct as it uses the neighbor address to set the update source address towards the neighbor. In order to fix this, the gRPC protobuf schema should allow setting this. This patch augments the protobuf schema with such a field.

The issue explains why we were seeing things like:

2025/05/20 12:29:52 BGP: [VZ06J-9VWXE][EC 100663299] can't bind socket for 7.0.0.2 : Cannot assign requested address

... because the config generated for FRR was:

 neighbor 7.0.0.2 update-source 7.0.0.2

which is incorrect.

In dataplane, this is temporarily fixed by githedgehog/dataplane#498

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/augment-proto-bgp-update-source branch from 7286672 to 64f65d6 Compare May 20, 2025 14:15
@Frostman
Copy link
Member

What values would you expect to be passed? Loopback with its ip?

@Fredi-raspall
Copy link
Contributor Author

What values would you expect to be passed? Loopback with its ip?

  • FRR can admit an IP address or an interface name.
  • I don't think we should speculate here (autogenerate) neither with ips nor interfaces.
  • Interface may not necessarily be the loopback. If we establish bgp per link, then it could be (ought to be) the interface name (or address). Given that, even with a bgp-only implementation, we may support distinct types of setups (some with multiple loopback interfaces or addresses), I think that the best option is to expose this.

@sergeymatov sergeymatov merged commit 6fabf79 into master May 26, 2025
4 checks passed
@Frostman Frostman deleted the pr/fredi/augment-proto-bgp-update-source branch June 2, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants